You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Neither solution works, because type declarations must be unique. I'm going to lift the capability request call out of the lookup so it happens on every type instead
Atomics and Scalars are collapsed to the same LocalType
https://github.com/gfx-rs/wgpu/blob/trunk/naga/src/back/spv/mod.rs#L360
Type capability requests are based on TypeInner
https://github.com/gfx-rs/wgpu/blob/trunk/naga/src/back/spv/writer.rs#L835
But deduplicated by LocalType
https://github.com/gfx-rs/wgpu/blob/trunk/naga/src/back/spv/writer.rs#L977
This means if an
atomic<u64>
is seen afteru64
, then the necessaryInt64Atomics
capability doesn't get requested.LocalType
should represent Atomic and non-Atomic types with distinct values, but I'm not sure how. Do we want aatomic: bool
or anAtomic {}
variant?The text was updated successfully, but these errors were encountered: