-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log spring cleaning #6065
Log spring cleaning #6065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks (very) good to me! :) expect that there's no changelog entry ;-)
(I think it's important to highlight in releases that we're putting in this kind of love for the health of the codebase!)
Let's see what the other maintainers have to say
This comment was marked as resolved.
This comment was marked as resolved.
I only have linux hardware to test on. The d3d12 backend might get a more noticeable boost since it was a fair bit more verbose than the other backends. Anyway, here are the results of running the render pass bench on linux:
|
Connections
#6046
Description
This PR removes a lot of trace and debug logging in code that tends to be exercised once for each frame in a typical application. Also demotes some logging from info to trace.
The motivation is to reduce the overall verbosity of our logs and shave off some of the overhead of checking the log levels when a log level is disabled at runtime, which is reportedly significant.
I have no doubt that some that logging we actually to want to keep so I invite every active wgpu maintainer to chime in and comment inline for each log they want to save.
The PR does not remove API logs, resource logs and the logging that happens during device initialization since it was already established that we want to keep them.
Checklist
cargo fmt
.cargo clippy
.cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.