Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm simd 128 build failure regression #804

Closed
xloem opened this issue Apr 6, 2023 · 3 comments
Closed

wasm simd 128 build failure regression #804

xloem opened this issue Apr 6, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@xloem
Copy link
Contributor

xloem commented Apr 6, 2023

I’m trying out building on a-shell on iOS which is a wasm terminal platform without gnu make.

It looks like since c1f8850 there are undefined symbols in the wasm simd 128 code:

clang -pipe  -msimd128 -D_WASI_EMULATED_MMAN -D_WASI_EMULATED_PROCESS_CLOCKS   -c ggml.c -o ggml.o
ggml.c:2090:43: error: use of undeclared identifier 'px'
        const block_q4_0 * restrict x0 = &px[i + 0];
                                          ^

These undefined symbols were first introduced on line 1726 of ggml.c c1f8850#diff-6d9ce99fcb6f51ff76f59e479f6e6fc0bb62edef7442805d7a5bb15b23996b5dR1726 (github seems to need the large diff manually expanded) and is presently at

llama.cpp/ggml.c

Line 2090 in d2beca9

const block_q4_0 * restrict x0 = &px[i + 0];

@xloem xloem changed the title wasm simd 128 build failure regession wasm simd 128 build failure regression Apr 6, 2023
@gjmulder gjmulder added the bug Something isn't working label Apr 6, 2023
@sw sw self-assigned this Apr 8, 2023
@sw
Copy link
Collaborator

sw commented Apr 8, 2023

@xloem : I apologize, I broke this without ever testing it in wasm. Unfortunately I can't seem to get the toolchain right here, because I'm still getting errors about wasm_u8x16_splat which I didn't touch in #356. Can you check if sw@d1315a3 works for you?

@xloem
Copy link
Contributor Author

xloem commented Apr 11, 2023

This error is resolved in the referenced commit. (I still haven’t performed a full build on this platform yet, it lacks gnu make and has a version of llvm from before there was full wasm pthread support)

@sw
Copy link
Collaborator

sw commented Apr 12, 2023

Was already fixed in the meantime by 461ba9e

@sw sw closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants