-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extremely slow compilation when silencer plugin enabled #45
Comments
very nice catch!! 👏 thank you for isolating and reporting |
fwiw, scala/scala#8373 doesn't seem to have this problem (tested with 2.13.2-bin-59cf05f-SNAPSHOT). I wonder what @lrytz did differently. (of course, it's easier to avoid extra traversals and such when something is integrated into the compiler directly, so perhaps there's no mystery.) |
This is caused by tapir's macros which seem to blow up exponentially. Silencer looks for I probably could just ignore macro expansions as it's very unlikely that someone would put |
Ok, I've decided to go on and ignore macro expansions by default. I've also introduced an option to bring back the old behaviour ( |
I wonder if tapir's maintainers know about that. |
@SethTisue yes :) softwaremill/tapir#455 |
Next lines of code compiles at least 25 seconds when silencer plugin enabled and just 1 seconds with disabled plugin
where
modify
- is macro function from tapir library.Repo with simple reproducer: https://github.com/igrocki/slow-silencer-tapir
I found ugly workaround: breaking method chain into two or more chains like:
The text was updated successfully, but these errors were encountered: