Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): simplify package TS Types exports #1402

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

ghiscoding
Copy link
Owner

  • we no longer need to specify TypeScript >=4.2 min version since at this point v4.2 is 3 years old, so most users have already upgraded. The TS builds changed after TypeScript v3.7 which is even older and even then the prior code was simply throwing anyway when using a version below 4.2 since it had no Types exports associated

- we no longer need to specify TypeScript >=4.2 min version since at this point v4.2 is 3 years old, so most users have already upgraded. The TS builds changed after TypeScript v3.7 which is even older and even then the prior code was simply throwing anyway when using a version below 4.2 since it had no Types exports associated
Copy link

stackblitz bot commented Feb 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d6bb1d7) 99.8% compared to head (f5de2d0) 99.8%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1402   +/-   ##
======================================
  Coverage    99.8%   99.8%           
======================================
  Files         199     199           
  Lines       21559   21559           
  Branches     7204    7204           
======================================
  Hits        21495   21495           
- Misses         58      64    +6     
+ Partials        6       0    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 19bac52 into master Feb 22, 2024
6 checks passed
@ghiscoding ghiscoding deleted the chore/simplify-package-exports branch February 22, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant