Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): bump ms-select to fix compatibility problem in Salesforce #1425

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

ghiscoding
Copy link
Owner

  • the new arrow navigation highlight that came out in ms-select v2.x wasn't working in Salesforce, after troubleshooting I found the issue to be a simple DOM query selector and so I fixed it in ms-select and pushed a new version which is included in this PR

- the new arrow navigation highlight that came out in ms-select v2.x wasn't working in Salesforce, after troubleshooting I found the issue to be a simple DOM query selector and so I fixed it in ms-select and pushed a new version which is included in this PR
Copy link

stackblitz bot commented Mar 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (373c312) to head (eb4c383).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1425    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         199     199            
  Lines       21611   21611            
  Branches     7229    7092   -137     
=======================================
  Hits        21547   21547            
+ Misses         64      58     -6     
- Partials        0       6     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit d3d2d39 into master Mar 8, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/ms-select-sf branch March 8, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants