Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): consider target size when auto-position picker/modal #1517

Merged
merged 1 commit into from
May 9, 2024

Conversation

ghiscoding
Copy link
Owner

  • when calculating picker/modal by available position, it should (wasn't) consider targeted element. For example when a calendar picker is reposition according to attached input
  • exact same change was applied to Vanilla-Calendar-Picker external dep, also remove it from unused package.json

- when calculating picker/modal by available position, it should (wasn't) consider targeted element. For example when a calendar picker is reposition according to attached input
- exact same change was applied to Vanilla-Calendar-Picker external dep, also remove it from unused package.json
Copy link

stackblitz bot commented May 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (ba68019) to head (eef8e8b).

Additional details and impacted files
@@          Coverage Diff           @@
##            next   #1517    +/-   ##
======================================
  Coverage   99.8%   99.8%            
======================================
  Files        198     198            
  Lines      21619   21619            
  Branches    7217    6947   -270     
======================================
  Hits       21555   21555            
  Misses        64      64            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit e3a70b8 into next May 9, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/picker-auto-position branch May 9, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant