feat(composite): add new validateMassUpdateChange callback & bug fixes
#603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a new method `validateMassUpdateChange` that user can provide which when returning false will skip changes on that item data context, it will be analyzed for each row - add `shouldPreviewMassChangeDataset` flag that when enabled will provide a preview of the dataset changes (mass update/selection) when calling the `onSave` function - fix column name showing plain html when `name` is provided as html instead of simple text. Basically `name` can accept html that will be rendered and we should do the same in the Composite modal window - also remove fixed button text, we will keep using translation keys instead
Codecov Report
@@ Coverage Diff @@
## master #603 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 230 230
Lines 16059 16068 +9
Branches 5172 5179 +7
=========================================
+ Hits 16059 16068 +9
Continue to review full report at Codecov.
|
AnnetteZhang
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateMassUpdateChangethat user can provide which when returning false will skip changes on that item data context, it will be analyzed for each rowshouldPreviewMassChangeDatasetflag that when enabled will provide a preview of the dataset changes (mass update/selection) when calling theonSavefunctionnameis provided as html instead of simple text. Basicallynamecan accept html that will be rendered and we should do the same in the Composite modal window