feat(common)!: migrate to multiple-select-vanilla #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiscoding
changed the title
Codecov Report
@@ Coverage Diff @@
## next #919 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 244 244
Lines 16604 16604
Branches 5906 5930 +24
=========================================
Hits 16604 16604
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ghiscoding
force-pushed
the
feat/multiple-select-vanilla
branch
from
5cf866b
to
63a33d2
Compare
ghiscoding
changed the title
ghiscoding
changed the title
- group duplicate code as much as possible to lower amount of lines with same css - also add missing ms-select png in demo
…ts (#938) - this PR fixes 2 issues 1. when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see print screen) 2. there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when columns presets are used
- switch from `multiple-select-modified` to [multiple-select-vanilla](https://github.com/ghiscoding/multiple-select-vanilla) which no longer requires jQuery - might release as a breaking change version since there is a very small change for the CSS import of the new lib, the MultipleSelectOption also no longer exist in Slickgrid-Universal but is instead in the new lib
- I wish to eventually revisit this and use a better fix but that will do for now
- we no longer need the multiple-select.png (it now uses css to draw icon) and its multiple-select.scss file since the new lib provides all of that
ghiscoding
force-pushed
the
feat/multiple-select-vanilla
branch
from
6f93e11
to
ec41bbc
Compare
ghiscoding
changed the title
ghiscoding
added a commit
that referenced
this pull request
Apr 15, 2023
* feat(common)!: migrate to multiple-select-vanilla - switch from `multiple-select-modified` to [multiple-select-vanilla](https://github.com/ghiscoding/multiple-select-vanilla) which no longer requires jQuery - might release as a breaking change version since there is a very small change for the CSS import of the new lib, the MultipleSelectOption also no longer exist in Slickgrid-Universal but is instead in the new lib
ghiscoding
added a commit
that referenced
this pull request
May 29, 2023
…cy (#976) * feat(common)!: migrate to multiple-select-vanilla (#919) * feat(common)!: migrate to multiple-select-vanilla - switch from `multiple-select-modified` to [multiple-select-vanilla](https://github.com/ghiscoding/multiple-select-vanilla) which no longer requires jQuery - might release as a breaking change version since there is a very small change for the CSS import of the new lib, the MultipleSelectOption also no longer exist in Slickgrid-Universal but is instead in the new lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple-select-modifiedto multiple-select-vanilla which no longer requires jQueryTODOs