feat!: drop jQuery requirement & use multiple-select-vanilla dependency #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(common)!: migrate to multiple-select-vanilla - switch from `multiple-select-modified` to [multiple-select-vanilla](https://github.com/ghiscoding/multiple-select-vanilla) which no longer requires jQuery - might release as a breaking change version since there is a very small change for the CSS import of the new lib, the MultipleSelectOption also no longer exist in Slickgrid-Universal but is instead in the new lib
* feat!: drop jQuery requirement - this is a breaking change and will require a new major version from SlickGrid
Codecov Report
@@ Coverage Diff @@
## master #976 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 244 244
Lines 16559 16554 -5
Branches 5906 5927 +21
=========================================
- Hits 16559 16554 -5
|
ghiscoding
changed the title
- fixes a styling issue found in Angular-Slickgrid, overriding SASS variables must be before the import not after. The issue found was that ms-select styling was overriding Slickgrid-Universal styling (mainly the $primary-color is what was observed to be different)
* chore: improve Slick interfaces and add new methods
ghiscoding
changed the title
ghiscoding
added a commit
that referenced
this pull request
Jun 28, 2023
- fix a regression bug introduced by PR #976 when migrating from ms-select to ms-select-vanilla, the text should be encode only when `renderHtmlEnabled` is enabled and not encoded when it's the flag is disabled, basically the html encode was set on the wrong condition
ghiscoding
added a commit
that referenced
this pull request
Jun 28, 2023
…ded (#1011) * fix(common): Select Filter/Editor regular text shouldn't be html encoded - fix a regression bug introduced by PR #976 when migrating from ms-select to ms-select-vanilla, the text should be encode only when `renderHtmlEnabled` is enabled and not encoded when it's the flag is disabled, basically the html encode was set on the wrong condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextand merging it into themasterbranch, it includes the following:multiple-select-modified(jQuery based) to the new libmultiple-select-vanillathat I rewrote in vanilla JS (aka native)4.0.0-beta.0version (soon to be officially released)This is in preparation for a Beta release, it's not an official release just yet since SlickGrid new major v4.0 is not yet official (it's in Beta)