chore: test with Python 3.12 #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@giampaolo, the "bsd-tests / openbsd" failure seems unrelated to the modifications in this PR. |
mayeut
force-pushed
the
update-cibuildwheel
branch
from
56e2e6d
to
8c0e3df
Compare
|
@giampaolo, Getting Python 3.12 working is more & more important with rc1 just around the corner. |
Signed-off-by: mayeut <[email protected]>
Signed-off-by: mayeut <[email protected]>
There can be some small rounding errors due to float precision and how the sum gets computed. Use assertAlmostEqual with default parameters (allows for 1e-7 absolute error). Signed-off-by: mayeut <[email protected]>
From https://docs.python.org/3/c-api/arg.html Deprecated since version 3.3, will be removed in version 3.12: Part of the old-style Py_UNICODE API; please migrate to using PyUnicode_AsWideCharString(). Signed-off-by: mayeut <[email protected]>
The test was relying on a context switch to happen given a number of iterations of a specific code. The test began to fail on python 3.12 on macOS. Use time.sleep to force a context switch. Signed-off-by: mayeut <[email protected]>
mayeut
force-pushed
the
update-cibuildwheel
branch
from
b56eebc
to
ac577a6
Compare
|
Thank you Matthieu. |
ddelange
added a commit
to ddelange/psutil
that referenced
this pull request
Jul 31, 2023
* 'master' of https://github.com/giampaolo/psutil: fix var unbound (giampaolo#2245) Fix a dead link in the documentation (giampaolo#2280) chore: test with Python 3.12 (giampaolo#2270) chore(ci): fix linters job warning (giampaolo#2269) make flake8 happy add a fix-unittests make target to fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Update cibuildwheel
Test with Python 3.12
Fix comparison of sum of floats
Remove usage of PyArg_ParseTuple "u" on Python 3