-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The subtitles stay when the character has just finished saying the line. #15
Comments
Hey @Holominanu, you're right, I programmed the extension in such a way that the subtitles get still shown until the next subtitles appear except when the silence is longer than just a few seconds. If the silence is longer than just a few seconds, the subtitles disappear. |
Love this extension, but I actually would like for the subtitle to disappear quickly. The reason for this is I want the English subtitle to flash so I can comprehend what's going on but I'd rather have my eyes follow the native language subtitle, or at least not spend too much time in "English mode". At least that was my idea. I tried tweaking my srt file to have each subtitle be only 0.5 s, and that didn't work, which is how I found my way here. |
Hi @jrc, thanks for your comment! Unfortunately, I don't have time at the moment to add this feature. But if you want to add it I will gladly accept it! |
Looks like this does the trick, though of course that changes the default behavior.
|
Thanks! I'll take a look at it tomorrow! |
@jrc, do you want to do a PR? Also, we only want to do this when the silence indicator is disabled. Because when it's enabled we want the subtitles to stick around til the next ones... |
For example, when the character says 'hello everyone' and finishes saying the sentence, during that moment of silence, the phrase 'hello everyone' still remains at the bottom, waiting for another character to say something.
The text was updated successfully, but these errors were encountered: