From bf56f339b5d34b393b429f5083064278cfdef1b2 Mon Sep 17 00:00:00 2001 From: Jan Stourac Date: Thu, 29 Aug 2024 09:02:40 +0200 Subject: [PATCH] [fix] the run-if condition for the rocm e2e tests job (#56074) Having the `||` means that even empty string is matched which results to this job being triggered everytime with any change to the repository. --- .../opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml | 2 +- .../notebooks/opendatahub-io-notebooks-main-presubmits.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml b/ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml index 847ec2a33824..b9f9ba48632b 100644 --- a/ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml +++ b/ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml @@ -2567,7 +2567,7 @@ tests: memory: 200Mi workflow: ipi-gcp - as: rocm-notebooks-e2e-tests - run_if_changed: (rocm\/ubi9-python-3.(9|11)\/*)||(jupyter\/datascience\/ubi9-python-3.(9|11)\/*)|(jupyter\/rocm\/pytorch\/ubi9-python-3.(9|11)\/*)||(jupyter\/rocm\/tensorflow\/ubi9-python-3.(9|11)\/*) + run_if_changed: (rocm\/ubi9-python-3.(9|11)\/*)|(jupyter\/datascience\/ubi9-python-3.(9|11)\/*)|(jupyter\/rocm\/pytorch\/ubi9-python-3.(9|11)\/*)|(jupyter\/rocm\/tensorflow\/ubi9-python-3.(9|11)\/*) steps: cluster_profile: gcp-opendatahub test: diff --git a/ci-operator/jobs/opendatahub-io/notebooks/opendatahub-io-notebooks-main-presubmits.yaml b/ci-operator/jobs/opendatahub-io/notebooks/opendatahub-io-notebooks-main-presubmits.yaml index 384cce2e7291..9ca15a340c08 100644 --- a/ci-operator/jobs/opendatahub-io/notebooks/opendatahub-io-notebooks-main-presubmits.yaml +++ b/ci-operator/jobs/opendatahub-io/notebooks/opendatahub-io-notebooks-main-presubmits.yaml @@ -3771,7 +3771,7 @@ presubmits: pj-rehearse.openshift.io/can-be-rehearsed: "true" name: pull-ci-opendatahub-io-notebooks-main-rocm-notebooks-e2e-tests rerun_command: /test rocm-notebooks-e2e-tests - run_if_changed: (rocm\/ubi9-python-3.(9|11)\/*)||(jupyter\/datascience\/ubi9-python-3.(9|11)\/*)|(jupyter\/rocm\/pytorch\/ubi9-python-3.(9|11)\/*)||(jupyter\/rocm\/tensorflow\/ubi9-python-3.(9|11)\/*) + run_if_changed: (rocm\/ubi9-python-3.(9|11)\/*)|(jupyter\/datascience\/ubi9-python-3.(9|11)\/*)|(jupyter\/rocm\/pytorch\/ubi9-python-3.(9|11)\/*)|(jupyter\/rocm\/tensorflow\/ubi9-python-3.(9|11)\/*) spec: containers: - args: