Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single File crashes Brave Browser 1.79 when saving page. #27

Closed
mario-grgic opened this issue Sep 20, 2024 · 13 comments
Closed

Single File crashes Brave Browser 1.79 when saving page. #27

mario-grgic opened this issue Sep 20, 2024 · 13 comments

Comments

@mario-grgic
Copy link

Describe the bug

I am on macOS 10.15 Sequoia and using Single File extension version 1.22.69 with Brave Browser Version 1.70.117 Chromium: 129.0.6668.59 (Official Build) (arm64)

Open any web page and then right click and select SingleFile/Annotate and Save page... Attempt to save the page and Brave Browser application exits. On next startup Brave says it didn't exit normally and restores the previous browser session.

Environment

  • OS: macOS 15.0 (24A335)
  • Browser: Brave Browser Version 1.70.117 Chromium: 129.0.6668.59 (Official Build) (arm64)
  • Version: 1.22.69
@Pantarou1
Copy link

Pantarou1 commented Sep 20, 2024

I also have this Issue now on Windows 11. Upon saving a Tab it goes through steps 1/3 , 2/3 and then just as the save part should show up the Brave-Browser crashes and closes.Upon restarting Brave tells me it didn't exit normally.It creates a .tmp file in my Downloads-Directory, but thats it. Restoring the Page or not didn't change the outcome.I've closed every tab i had open , restarted the PC, cleared the Browser Cache and reinstalled SingleFile to no avail.I hope this can be resolved, I'm using Single-File daily and depend on it's Saving feature.

@dmryoz
Copy link

dmryoz commented Sep 21, 2024

I have same issue both on MacOS 14.5 and Win10

@gildas-lormeau
Copy link
Owner

I'll look into it, but at first glance, it's a bug in Brave. As a general rule, if an extension crashes a browser, it's a browser bug. It seems that some other extensions suffer from the same problem, cf.:

@gildas-lormeau
Copy link
Owner

I confirm I was able to reproduce the issue after updating Brave. You can circumvent it by disabling the option Misc. > save pages in background in SingleFile.

@gildas-lormeau
Copy link
Owner

Issue in the repository of Brave: brave/brave-browser#41179

@mario-grgic
Copy link
Author

@gildas-lormeau Thank you for doing the investigation and posting the ticked in Brave repo. The workaround you suggested also works.

@Pantarou1
Copy link

@gildas-lormeau Thank you very much for looking into this. Your workaround works fine , and since it mentions that "Save as ..." will remember the last saved directory by disabling the background-saving, i will actually use this going forward since i wanted this behaviour anyway. Thumbs up !

@MagnetoPause
Copy link

Experiencing same issue. It appears a similar extension "Save Page WE" seems to be working in Brave without crashing it.

@MagnetoPause
Copy link

I confirm I was able to reproduce the issue after updating Brave. You can circumvent it by disabling the option Misc. > save pages in background in SingleFile.

Thanks, this works!

@iefremov
Copy link

This is fixed in brave/brave-browser#41179

@gildas-lormeau
Copy link
Owner

Thank you very much for the info and the quick fix @iefremov!

@Pantarou1
Copy link

Thank you !

@mario-grgic
Copy link
Author

This is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants