Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

File permission #92

Closed
manny73 opened this issue Jul 25, 2019 · 7 comments
Closed

File permission #92

manny73 opened this issue Jul 25, 2019 · 7 comments

Comments

@manny73
Copy link

manny73 commented Jul 25, 2019

Hi, congratulations for this great software.
When the image are saved, in linux environment the file permission is rw- --- --- .
It's possibile to configure the mask, for the folder too?
For example file: rw- rw- -- and folder: rwx rwx x

Thanks

@gilesknap
Copy link
Owner

Hi, there is currently no option to control the file permissions.

This is a reasonable feature request. I'll add it to the list.

Does anyone else fancy contributing this feature? (see comments in #79 since this is quite similar)

@gilesknap gilesknap added this to the Next Issues ro Address milestone Jul 25, 2019
@gilesknap
Copy link
Owner

I'm wondering if it makes more sense to use umask in the script from which you launch gphotos-sync?

@gilesknap
Copy link
Owner

Actually, I just tried and that does not work.

If gphotos-sync honoured umask would that be OK?

@gilesknap
Copy link
Owner

I believe the umask is ignored because tempfile tries to be secure https://docs.python.org/2/library/tempfile.html. So I will have to explicitly set the permissions after download completes.

@manny73
Copy link
Author

manny73 commented Jul 26, 2019

If gphotos-sync honoured umask would that be OK?

it would be perfect. Thanks.

@gilesknap
Copy link
Owner

this should be fixed in 2.9.2 (on pypi) please give it a go.

Now umask determines the permissions on downloaded files (BUT this only works on Linux)

@manny73
Copy link
Author

manny73 commented Jul 31, 2019

Hi Giles, has working correctly!
Great job.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants