Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Help] indirect require package [github.com/go-playground/locales] too big #3165

Open
Laotree opened this issue May 31, 2022 · 2 comments
Open

Comments

@Laotree
Copy link

Laotree commented May 31, 2022

Description

I use gin as my web framework. everytime I packup my binary file, in a pure container, it always cost too much time to download locales package
since gin which less than 3M, requires locales indirectly, I repeatly download which more than 30M
could gin remove locales or replace it with a smaller requirement?

go mod why github.com/go-playground/locales                                                                                                                                                         
# github.com/go-playground/locales
github.com/gin-gonic/gin/binding
github.com/go-playground/validator/v10
github.com/go-playground/universal-translator
github.com/go-playground/locales
@thinkerou
Copy link
Member

maybe commit issue to here: https://github.com/go-playground/validator/issues

@Laotree
Copy link
Author

Laotree commented Jun 7, 2022

maybe commit issue to here: https://github.com/go-playground/validator/issues

Validation is self-defined in beego , so I think if there is a option for gin to build its own validation package?
For now, it's not a graceful solution to require locales indirectly, considering its size and only used in validation. Strongly suggest you guys think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants