fix(post): simplification du sujet des Post
#748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentporte
changed the title
Post
calummackervoy
approved these changes
Aug 12, 2024
Comment on lines
-48
to
-49
| if self.user.is_anonymous: | ||
| post.username = self.cleaned_data["username"] |
There was a problem hiding this comment.
Je vois que il y a un test qui confirme on peut enlever ce code
| assert set(response.context_data["post_form"].fields["tags"].initial) == set(Tag.objects.all()) | ||
|
|
||
|
|
||
| class TestPostForm: |
vincentporte
pushed a commit
that referenced
this pull request
Sep 9, 2024
🤖 I have created a release *beep* *boop* --- ## [2.13.0](v2.12.0...v2.13.0) (2024-09-05) ### Features * **event:** amélioration de l'admin ([#753](#753)) ([ca56d83](ca56d83)) * **forum:** retrait des communautés privées ([#768](#768)) ([1c120e3](1c120e3)) * **partner:** ajout des pages partenaires ([#757](#757)) ([33fd1c6](33fd1c6)) * **partner:** améliorations post déploiement ([#763](#763)) ([09a865f](09a865f)) * **partner:** lien avec les fiches pratiques ([#761](#761)) ([60bb2ee](60bb2ee)) * **partner:** referencer les fiches partenaires dans sitemap.xml ([#759](#759)) ([91bea96](91bea96)) * **tags:** afficher les filtres sur les tags ([#752](#752)) ([7a10488](7a10488)) * **tags:** afficher les Tags dans la liste des fiches pratiques d'une categorie ([#751](#751)) ([ed005b7](ed005b7)) * **tags:** ajouter des étiquettes à un forum ([#746](#746)) ([7f435bb](7f435bb)) * **tags:** ajouter une étiquette inexistante à un sujet ([#744](#744)) ([b82ea73](b82ea73)) * **tags:** filtrer les `forum` enfants à partir des tags ([#750](#750)) ([eb6683a](eb6683a)) ### Bug Fixes * **forum_conversation:** Résolution des erreurs de tests sur les contenus des messages ([#754](#754)) ([8e0f35d](8e0f35d)) * **partner:** mise en forme des logos de la vue en liste ([#764](#764)) ([7a84319](7a84319)) * **post:** simplification du sujet des `Post` ([#748](#748)) ([3c2a5a0](3c2a5a0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 Les
Postde réponse d'unTopic(à partir du 2e, jusqu'au dernier), conservent le même sujet que leTopic. LeTOPIC_ANSWER_SUBJECT_PREFIXest supprimé pour améliorer la qualité des emails de notification.🎸 Optimisation & simplification de
TopicFormetPostFormType de changement
🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).
🚧 technique
Points d'attention
🦺 Suppression du code dupliqué dans
PostFormet dansTopicFormavec le code dedjango-machina, et ajout des tests correspondants🦺 Simplification de la méthode
initdeTopicForm, et ajout des tests correspondants