Add TSDoc, style and className props
#543
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Thanks for the effort, though I'm not sure if this would work. Also, if we're adding docs, I'd love it if it's added to all of the components instead of just doing this for React. Not sure if there's a way to not duplicate the docs across different files, it would be very nice if it's possible to use a single source for the docs...
| @@ -30,6 +32,8 @@ export default function Giscus({ | |||
|
|
|||
| return ( | |||
| <giscus-widget | |||
| style={style} | |||
| className={className} | |||
There was a problem hiding this comment.
Does this work? It's a custom element so I doubt this could just work as-is, since the element doesn't explicitly accept style and class attributes.
| id?: string; | ||
| host?: string; | ||
| repo: `${string}/${string}`; | ||
| repoid: string; | ||
| category?: string; | ||
| categoryid?: string; | ||
| categoryid: string; |
There was a problem hiding this comment.
This isn't required if the chosen mapping is number.
|
@laymonage, I can check this the days, but I don't know so much over Angular and Vue |
I added some TSDocs to the Giscus type definition. I also added
styleandclassNameprops for inline styling. Class name is useful for styled componentsFeel free to make/open requests :D