New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in 1.3.4: discarding file changes during rewrite deletes the whole file #885

Closed

jfirebaugh opened this issue Dec 16, 2022 · 1 comment

Assignees

Labels

bug

jfirebaugh commented Dec 16, 2022

To reproduce:

Select "Rewrite..." on some commit
Click "Discard File Changes..."

Expected result: File is removed from diff
Actual result: File is deleted entirely in diff

Works as expected in 1.3.2.

lucasderraugh self-assigned this

lucasderraugh added the bug label

lucasderraugh closed this as completed in

9a7787e

Collaborator

lucasderraugh commented Jan 4, 2023 •

edited

Loading

Will be addressed in 1.3.5.

We made changes in e060ece that were meant to assist in bulk discard/stage operations, but there were some bugs in the handling of that.

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment