Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limits the issue list to 30 while generating release notes #209

Open
amit-mhetre opened this issue May 20, 2019 · 4 comments
Open

Limits the issue list to 30 while generating release notes #209

amit-mhetre opened this issue May 20, 2019 · 4 comments

Comments

@amit-mhetre
Copy link

When I try to generate release notes which has issues more than 30, it ignores the the issues after 30th issue. Below is the logs I am getting while generating relase notes.

🤖  - Generate release notes:
===================================
✔ Releases found: 1
✔ Tags found: v1.0, starting_v1.0_implementation
✔ Issues found: 30

May I know, how we can change the count of issues to be consider while generating notes.

@amit-mhetre amit-mhetre changed the title Limiting the issue list to 30 while generating release notes Limits the issue list to 30 while generating release notes May 20, 2019
@SamuelHassine
Copy link

Hello,

I have the same problem and it seems to be linked to the Github rate limit, anyone has a solution?

Thanks!

@omerlh
Copy link

omerlh commented Jul 1, 2019

I think this is the root issue: github-tools/github#569. I was managed to bypass this issue by requesting more items. Change this line to add the maximum items per page (as documented here):

        const { data: issues } = await this.issues.listIssues({
            state: 'closed',
            since: releaseRanges[releaseRanges.length - 1][1].date,
            per_page: 100
        });

@amit-mhetre
Copy link
Author

amit-mhetre commented Jul 1, 2019

per_page: 100

Thanks @omerlh
This solution worked for me. But I think it doesn't fetch the issues more than 100 even though we set the number which is greater than 100. Do you have any idea about this?
Once again thanks!

@omerlh
Copy link

omerlh commented Jul 1, 2019

Yep, 100 is the limit :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants