From 56b841888472b4f479ef3b9c0643f73434756177 Mon Sep 17 00:00:00 2001 From: Andrew Eisenberg Date: Mon, 9 Sep 2024 14:59:49 -0700 Subject: [PATCH] Ignore suppressed alerts --- .eslintignore | 4 ---- .github/workflows/pr-checks.yml | 5 +---- .gitignore | 2 ++ package.json | 2 +- 4 files changed, 4 insertions(+), 9 deletions(-) delete mode 100644 .eslintignore diff --git a/.eslintignore b/.eslintignore deleted file mode 100644 index b4a55a0976..0000000000 --- a/.eslintignore +++ /dev/null @@ -1,4 +0,0 @@ -**/webpack.config.js -lib/** -src/testdata/** -tests/** diff --git a/.github/workflows/pr-checks.yml b/.github/workflows/pr-checks.yml index da28a7dbf4..cfb4c1ab0c 100644 --- a/.github/workflows/pr-checks.yml +++ b/.github/workflows/pr-checks.yml @@ -28,15 +28,12 @@ jobs: - name: Upload sarif uses: github/codeql-action/upload-sarif@v3 - # Only upload SARIF for the latest version of Node.js + # Only upload SARIF for the latest version of Node.js if: matrix.node-types-version == 'current' with: sarif_file: eslint.sarif category: eslint - - name: Ensure the working directory is clean - run: rm -f eslint.sarif - - name: Update version of @types/node if: matrix.node-types-version != 'current' env: diff --git a/.gitignore b/.gitignore index 8731db69c1..c1be11d2ac 100644 --- a/.gitignore +++ b/.gitignore @@ -5,3 +5,5 @@ node_modules/.cache/ *.class # macOS .DS_Store +# eslint sarif report +eslint.sarif diff --git a/package.json b/package.json index 35d455fe95..e44afaeae5 100644 --- a/package.json +++ b/package.json @@ -9,7 +9,7 @@ "test-debug": "ava src/**.test.ts --serial --verbose --timeout=20m", "lint": "eslint --report-unused-disable-directives --max-warnings=0 .", "lint-fix": "eslint --report-unused-disable-directives --max-warnings=0 . --fix", - "lint-ci": "eslint --report-unused-disable-directives --max-warnings=0 . --format @microsoft/eslint-formatter-sarif --output-file=eslint.sarif", + "lint-ci": "SARIF_ESLINT_IGNORE_SUPPRESSED=true eslint --report-unused-disable-directives --max-warnings=0 . --format @microsoft/eslint-formatter-sarif --output-file=eslint.sarif", "removeNPMAbsolutePaths": "removeNPMAbsolutePaths . --force" }, "ava": {