Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running fallback Go autobuild if database is finalized #1405

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

angelapwen
Copy link
Contributor

@angelapwen angelapwen commented Dec 1, 2022

When we implemented Go extraction reconciliation, we added a step to autobuild Go in the analyze action if the autobuilder was not already run, or if there were no custom build steps, to maintain backwards compatibility with customers who may not have set either. This PR adds logic to also not autobuild Go in analyze if a Go database has already been finalized — a finalized database directory may have been manually specified in the init step.

I have not added a PR check to test, because I'm not sure this use case is common enough to check in a finalized database and justify adding another step to CI.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen marked this pull request as ready for review December 1, 2022 09:29
@angelapwen angelapwen requested a review from a team as a code owner December 1, 2022 09:29
@angelapwen angelapwen merged commit 9af9a11 into github:main Dec 1, 2022
@angelapwen angelapwen deleted the go-finalized-db branch December 1, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants