Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch event's activity type starred is wrong. The correct activity type is started #27129

Closed
1 task done
suzuki-shunsuke opened this issue Jul 28, 2023 · 3 comments · Fixed by #27127
Closed
1 task done
Labels
content This issue or pull request belongs to the Docs Content team

Comments

@suzuki-shunsuke
Copy link
Contributor

suzuki-shunsuke commented Jul 28, 2023

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#watch

What part(s) of the article would you like to see updated?

image

watch event's action type starred is wrong. The correct action type is started.
The example code doesn't trigger workflows even if a repository is starred.

Additional information

I created a repository to reproduce the issue.

https://github.com/suzuki-shunsuke/github-docs-27127

I created a pull request to resolve this issue.

The webhook action is not starred but started.

https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads#watch

Webhook payload object for watch
Someone started watching the repository.
Webhook request body parameters
Name, Type, Description
action string Required
Value: started

image
@suzuki-shunsuke suzuki-shunsuke added the content This issue or pull request belongs to the Docs Content team label Jul 28, 2023
@welcome
Copy link

welcome bot commented Jul 28, 2023

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 28, 2023
@suzuki-shunsuke
Copy link
Contributor Author

suzuki-shunsuke commented Jul 28, 2023

Previously, the activity type was correct.
But the activity type was changed wrongly by this pull request.

@steveward pointed out it, but the pull request was merged. I'm not sure why the pull request was merged.

@suzuki-shunsuke suzuki-shunsuke changed the title watch event's action type starred is wrong. The correct action type is started watch event's activity type starred is wrong. The correct action type is started Jul 28, 2023
@suzuki-shunsuke suzuki-shunsuke changed the title watch event's activity type starred is wrong. The correct action type is started watch event's activity type starred is wrong. The correct activity type is started Jul 28, 2023
@cmwilson21
Copy link
Contributor

@suzuki-shunsuke Thank you for opening an issue and linking it to your PR! ✨

@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@suzuki-shunsuke @cmwilson21 and others