Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages: misleading description about deprecated code highlighter pygments #30152

Closed
1 task done
muzimuzhi opened this issue Nov 22, 2023 · 7 comments · Fixed by #31808
Closed
1 task done

Pages: misleading description about deprecated code highlighter pygments #30152

muzimuzhi opened this issue Nov 22, 2023 · 7 comments · Fixed by #31808
Labels
content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue pages Content related to GitHub Pages

Comments

@muzimuzhi
Copy link
Contributor

muzimuzhi commented Nov 22, 2023

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/about-github-pages-and-jekyll#syntax-highlighting

What part(s) of the article would you like to see updated?

Currently the section "Syntax highlighting" says

By default, code blocks on your site will be highlighted by Jekyll. Jekyll uses the Rouge highlighter, which is compatible with Pygments. Pygments has been deprecated and not supported in Jekyll 4.

This may mislead readers that GitHub Pages already uses Jekyll 4, while actually it still uses Jekyll 3.9.3. See

Additional information

What "Pygments has been deprecated and not supported in Jekyll 4." (added in 724a274) said is true, but it's not the appropriate reason. pgyments was deprecated because GitHub Pages wanted to, not because the version of Jekyll used by GitHub Pages dropped support for it.

Pygments support was dropped

@muzimuzhi muzimuzhi added the content This issue or pull request belongs to the Docs Content team label Nov 22, 2023
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 22, 2023
@muzimuzhi muzimuzhi changed the title Pages: inaccurate description about deprecated code highlighter pygments Pages: misleading description about deprecated code highlighter pygments Nov 22, 2023
@janiceilene
Copy link
Contributor

👋 @muzimuzhi Thanks so much for opening an issue! I'll get this triaged for review ✨

@janiceilene janiceilene added waiting for review Issue/PR is waiting for a writer's review pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels Nov 22, 2023
@Alexx65we39

This comment was marked as spam.

1 similar comment
@Alexx65we39

This comment was marked as spam.

@sophietheking
Copy link
Contributor

sophietheking commented Jan 23, 2024

@muzimuzhi 👋 Thanks for opening this issue and contributing to our Docs, we really appreciate it. It looks like everything after the comma can be can be removed:

, which is compatible with Pygments. Pygments has been deprecated and not supported in Jekyll 4.

So it reads:

By default, code blocks on your site will be highlighted by Jekyll. Jekyll uses the Rouge highlighter.

You or anyone else is welcome to open a PR. 🔨

@sophietheking sophietheking added help wanted Anyone is welcome to open a pull request to fix this issue and removed waiting for review Issue/PR is waiting for a writer's review labels Jan 23, 2024
@janbrasna
Copy link
Contributor

@sophietheking Actually I think the compatibility bit is important, so I've kept it in #31808 — otherwise agree.

@muzimuzhi
Copy link
Contributor Author

@janbrasna Agreed with you. And thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue pages Content related to GitHub Pages
Projects
None yet
7 participants
@janbrasna @muzimuzhi @janiceilene @sophietheking @Alexx65we39 and others