Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs.<job_id>.steps[*].timeout-minutes doesn't describe input < 1, or give examples #34685

Closed
1 task done
hamirmahal opened this issue Sep 21, 2024 · 9 comments · Fixed by #34879
Closed
1 task done
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR

Comments

@hamirmahal
Copy link
Contributor

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstepstimeout-minutes

What part(s) of the article would you like to see updated?

  1. The docs should say what happens if users try to set timeout-minutes to a value less than 1, like 0.01.
  2. The docs should give correct example usage for that property.

Additional information

No response

@hamirmahal hamirmahal added the content This issue or pull request belongs to the Docs Content team label Sep 21, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 21, 2024
@hamirmahal
Copy link
Contributor Author

For 2, something like

my-job:
 runs-on:         ubuntu-latest
 timeout-minutes: 30

from https://stackoverflow.com/questions/59073731/set-default-timeout-on-github-action-pipeline would work well.

@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 23, 2024
@nguyenalex836
Copy link
Contributor

@hamirmahal Thank you for raising this issue! I'll get this triaged for review ✨ Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@hamirmahal
Copy link
Contributor Author

@nguyenalex836 You're welcome!

@subatoi subatoi added the needs SME This proposal needs review from a subject matter expert label Sep 24, 2024
Copy link
Contributor

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836
Copy link
Contributor

@hamirmahal Thank you so much for your patience while our SME team reviewed! 💛

Upon testing, they found that fractional values are unsupported. They advise to add a note that the value of timeout-minutes needs to be a positive integer value.

I have added the help wanted label so that you, or anyone else, may open a PR to make this update ✨ thank you again for raising this issue!

@nguyenalex836 nguyenalex836 added help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Oct 9, 2024
@Nmt112

This comment was marked as spam.

@hamirmahal
Copy link
Contributor Author

@nguyenalex836 You're welcome! Would you like any other changes to #34879?

@hamirmahal
Copy link
Contributor Author

Out of curiosity, where can I find metrics for https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions?

It'd be interesting to see how many views that page gets, and how much usage docs.github.com gets in general.

@nguyenalex836
Copy link
Contributor

@nguyenalex836 You're welcome! Would you like any other changes to #34879?

Your changes look perfect ✨ getting that merged now!

Out of curiosity, where can I find metrics for https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions?

Let me do some digging, and I'll get back to you! 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team help wanted Anyone is welcome to open a pull request to fix this issue SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants