-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for passing a list of ldap servers #96
Conversation
We need this so we can take advantage of the `hosts` option
We don't care too much about the port in testing. Using the port in the options allows us to test against ApacheDS and OpenLDAP without adding any additional conditionals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me 👍
Can I make a new release too? If so v1.10.1 or v1.11.0? |
@lildude yep, what is your rubygems email? I can add you as an owner so you can cut releases |
I didn't have one, but I do now 😄 [email protected] |
ruby-ldap/ruby-net-ldap#223 introduced the ability to configure net-ldap to use an array of hostnames and ports, with basic failover support.
This PR adds the ability to pass this same array to net-ldap via github-ldap so this basic failover functionality can be used by github-ldap related projects too.
/cc @jch @mtodd @sbryant