-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ABAP CDS #4614
Add support for ABAP CDS #4614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've downloaded the 804 files associated to this extension using Harvester and found 104 repositories by 51 users. This is clearly low given our requirements. The extension is also unlikely to conflict with another one. I'll leave the final decision to @lildude.
The pull request looks good to me otherwise.
Yeah, unfortunately still too low. Popularity for inclusion is based on GitHub.com stats as that's the only thing we can measure. It's probably best to add this to #4219 and monitor the growth. |
Alright I guess. I'll try to motivate people to host more of their code on github, but unfortunately, most devs within my reach simply can't make their code public. This is purely philosophical rambling from my side as I'm aware you currently don't have a better metric to judge popularity by, but: I'm taking the "build it and they'll come" approach, but in this case, they need to come before I can build it, which is a bit of a conundrum. SAP is used by major companies which can be very resistant to change and have yet to adopt proper versioning and open source practices, but somehow expect perfect tooling to be available before they move a finger. As github is almost the de facto standard place for sharing code, lack of support there can thwart adoption of the language (and the practices). Anyway, I'm sure this will resolve itself over time, I'd just like to make that time shorter. |
Please keep in mind the github enterprise use case. @FreHu , I can also see people using the extensions |
No, because Why we name languages so similarly we can't tell them apart is beyond me. Also the usage has to be per extension, not in total. |
Closing in favor of #4219. We'll monitor the popularity of the extension there. |
Good news, popularity of the |
Support for ABAP CDS was introduces with PR github-linguist#4614. ".acds" is just another alternative file extension to ".asddls". This is officially documented by SAP in https://github.com/SAP/abap-file-formats See: - https://github.com/SAP/abap-file-formats/blob/main/docs/specification.md - https://github.com/SAP/abap-file-formats/tree/main/file-formats/ddls/examples - https://github.com/SAP/abap-file-formats/tree/main/file-formats/ddlx/examples
With github-linguist/linguist#4614 Github understands "asddls" files and uses the syntax coloring provided by https://github.com/FreHu/abap-cds-grammar Let's use an override for this repo so that acds files just use the existing coloring for "asddls". This is explained in: https://github.com/github/linguist/blob/master/docs/overrides.md Fixes: #371
With github-linguist/linguist#4614 Github understands "asddls" files and uses the syntax coloring provided by https://github.com/FreHu/abap-cds-grammar Let's use an override for this repo so that acds files just use the existing coloring for "asddls". This is explained in: https://github.com/github/linguist/blob/master/docs/overrides.md Fixes: #371
Already tried in #4592, but the repo had issues with the license and build. Submitting again with a new repo (and color). The grammar is exactly the same, but the repo does not contain the incompatibly licensed snippets.
As previously discussed, I'm only including one of the extensions for popularity reasons. Hopefully this will improve in the future.
Description
Hi! This PR adds support for the ABAP CDS language, which is used for defining what is basically database views on steroids. It goes hand in hand with the ABAP language, which is already recognized.
The language is not widely used outside of the SAP ecosystem, but even the public github contains a number of repositories now. Many more can be found on github enterprise servers.
Checklist:
https://github.com/hardyp/AbapToTheFuture03/tree/master/src/zmonsters_p02_transactional/zmonsters_c07_database
Notes