Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ABAP CDS #4614

Merged
merged 12 commits into from
Feb 12, 2021
Merged

Add support for ABAP CDS #4614

merged 12 commits into from
Feb 12, 2021

Conversation

FreHu
Copy link
Contributor

@FreHu FreHu commented Aug 20, 2019

Already tried in #4592, but the repo had issues with the license and build. Submitting again with a new repo (and color). The grammar is exactly the same, but the repo does not contain the incompatibly licensed snippets.

As previously discussed, I'm only including one of the extensions for popularity reasons. Hopefully this will improve in the future.

Description

Hi! This PR adds support for the ABAP CDS language, which is used for defining what is basically database views on steroids. It goes hand in hand with the ABAP language, which is already recognized.

The language is not widely used outside of the SAP ecosystem, but even the public github contains a number of repositories now. Many more can be found on github enterprise servers.

Checklist:

Notes

  • To simplify legal matters, I would like to note that though I am a SAP employee, I am making this request as my own person in my spare time and not on behalf of SAP.

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've downloaded the 804 files associated to this extension using Harvester and found 104 repositories by 51 users. This is clearly low given our requirements. The extension is also unlikely to conflict with another one. I'll leave the final decision to @lildude.

The pull request looks good to me otherwise.

@lildude
Copy link
Member

lildude commented Aug 21, 2019

I've downloaded the 804 files associated to this extension using Harvester and found 104 repositories by 51 users. This is clearly low given our requirements.

Yeah, unfortunately still too low. Popularity for inclusion is based on GitHub.com stats as that's the only thing we can measure. It's probably best to add this to #4219 and monitor the growth.

@FreHu
Copy link
Contributor Author

FreHu commented Aug 21, 2019

Alright I guess. I'll try to motivate people to host more of their code on github, but unfortunately, most devs within my reach simply can't make their code public.

This is purely philosophical rambling from my side as I'm aware you currently don't have a better metric to judge popularity by, but:

I'm taking the "build it and they'll come" approach, but in this case, they need to come before I can build it, which is a bit of a conundrum. SAP is used by major companies which can be very resistant to change and have yet to adopt proper versioning and open source practices, but somehow expect perfect tooling to be available before they move a finger. As github is almost the de facto standard place for sharing code, lack of support there can thwart adoption of the language (and the practices).

Anyway, I'm sure this will resolve itself over time, I'd just like to make that time shorter.

@dellagustin
Copy link

dellagustin commented Aug 28, 2019

Please keep in mind the github enterprise use case.
ABAP code is not often made open source, but I bet there are a number of companies already hosting their ABAP code on their enterprise instances.

@FreHu , I can also see people using the extensions .cds (80 code results) and hdbcds (727 code results), does it make sense to extend your PR to also cover these two extensions?

@FreHu
Copy link
Contributor Author

FreHu commented Aug 28, 2019

No, because .cds and .hdbcds are a different language - CAP CDS. This request adds ABAP CDS.

Why we name languages so similarly we can't tell them apart is beyond me.

Also the usage has to be per extension, not in total.

@pchaigno
Copy link
Contributor

pchaigno commented Aug 31, 2019

Closing in favor of #4219. We'll monitor the popularity of the extension there.

@pchaigno pchaigno closed this Aug 31, 2019
@pchaigno pchaigno removed their assignment Aug 31, 2019
@lildude
Copy link
Member

lildude commented Feb 12, 2021

Good news, popularity of the .asddls extension is now sufficient for inclusion so I'm re-opening this PR.

@lildude lildude reopened this Feb 12, 2021
@lildude lildude requested a review from a team as a code owner February 12, 2021 10:11
@lildude lildude merged commit 9bcbcb8 into github-linguist:master Feb 12, 2021
BeckerWdf added a commit to SAP/abap-file-formats that referenced this pull request Jun 29, 2022
With github-linguist/linguist#4614 Github understands "asddls" files and uses
the syntax coloring provided by
https://github.com/FreHu/abap-cds-grammar

Let's use an override for this repo so that acds files just use the
existing coloring for "asddls".
This is explained in:
https://github.com/github/linguist/blob/master/docs/overrides.md

Fixes: #371
BeckerWdf added a commit to SAP/abap-file-formats that referenced this pull request Jun 29, 2022
With github-linguist/linguist#4614 Github understands "asddls" files and uses
the syntax coloring provided by
https://github.com/FreHu/abap-cds-grammar

Let's use an override for this repo so that acds files just use the
existing coloring for "asddls".
This is explained in:
https://github.com/github/linguist/blob/master/docs/overrides.md

Fixes: #371
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants