Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ruby 2.7.1 in Dockerfile.alpine #759

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Conversation

waldyrious
Copy link
Contributor

This matches the actual version of Ruby used by GitHub pages, as specified in .ruby-version.

On master:

$ docker build -t gh-pages .
Sending build context to Docker daemon  886.3kB
Step 1/9 : FROM ruby:alpine
alpine: Pulling from library/ruby
4c0d98bf9879: Pull complete
e5fcc264663b: Pull complete
1c151e279a03: Pull complete
5ba67da12582: Pull complete
0816342c8486: Pull complete
Digest: sha256:5a1e0a3cf60f570854391b215cb33fe625bf21b90195909d540625b5becd293a
Status: Downloaded newer image for ruby:alpine
 ---> 91cbdb8db2c7


$ docker run --rm -it gh-pages /bin/sh
/src/site # ruby -v
ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [x86_64-linux-musl]

On this branch:

$ docker build -t gh-pages .
Sending build context to Docker daemon  886.3kB
Step 1/9 : FROM ruby:2.7.1-alpine
2.7.1-alpine: Pulling from library/ruby
df20fa9351a1: Pull complete
b79bab524d4c: Pull complete
8f5dd72031b5: Pull complete
bea36b8d88de: Pull complete
3396c77940f8: Pull complete
Digest: sha256:73814d17e9f746ca21a67a4cde96ab81e858bbe9e6bf78257fbb5def033f2b82
Status: Downloaded newer image for ruby:2.7.1-alpine
 ---> b46ea0bc5984


$ docker run --rm -it gh-pages /bin/sh
/src/site # ruby -v
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-linux-musl]

/cc @casperdcl from #560.

This matches the version used in the main Dockerfile
and specified in `.ruby-version`
Copy link
Contributor

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@parkr parkr merged commit 2186852 into github:master Feb 9, 2021
@waldyrious waldyrious deleted the patch-1 branch February 9, 2021 22:32
@casperdcl
Copy link
Contributor

Would have to be updated whenever .ruby-version is bumped, though, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants