From ac60ba3a4934e1223e5f16a40128db4b5e66f4b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nora=20Dimitrijevi=C4=87?= Date: Fri, 21 Jun 2024 17:47:31 +0200 Subject: [PATCH] Enable BigInt results in Quick Evals --- extensions/ql-vscode/src/common/bqrs-cli-types.ts | 7 +++++-- .../ql-vscode/src/common/bqrs-raw-results-mapper.ts | 2 ++ extensions/ql-vscode/src/common/raw-result-types.ts | 9 ++++++++- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/extensions/ql-vscode/src/common/bqrs-cli-types.ts b/extensions/ql-vscode/src/common/bqrs-cli-types.ts index 2eb565a7215..e9e726957e3 100644 --- a/extensions/ql-vscode/src/common/bqrs-cli-types.ts +++ b/extensions/ql-vscode/src/common/bqrs-cli-types.ts @@ -11,6 +11,7 @@ export namespace BqrsColumnKindCode { export const BOOLEAN = "b"; export const DATE = "d"; export const ENTITY = "e"; + export const BIGINT = "z"; } export type BqrsColumnKind = @@ -19,7 +20,8 @@ export type BqrsColumnKind = | typeof BqrsColumnKindCode.STRING | typeof BqrsColumnKindCode.BOOLEAN | typeof BqrsColumnKindCode.DATE - | typeof BqrsColumnKindCode.ENTITY; + | typeof BqrsColumnKindCode.ENTITY + | typeof BqrsColumnKindCode.BIGINT; export interface BqrsSchemaColumn { name?: string; @@ -79,7 +81,8 @@ export type BqrsKind = | "Integer" | "Boolean" | "Date" - | "Entity"; + | "Entity" + | "BigInt"; interface BqrsColumn { name?: string; diff --git a/extensions/ql-vscode/src/common/bqrs-raw-results-mapper.ts b/extensions/ql-vscode/src/common/bqrs-raw-results-mapper.ts index 1074f9b8979..10bd5fe9e33 100644 --- a/extensions/ql-vscode/src/common/bqrs-raw-results-mapper.ts +++ b/extensions/ql-vscode/src/common/bqrs-raw-results-mapper.ts @@ -76,6 +76,8 @@ function mapColumnKind(kind: BqrsColumnKind): ColumnKind { return ColumnKind.Date; case BqrsColumnKindCode.ENTITY: return ColumnKind.Entity; + case BqrsColumnKindCode.BIGINT: + return ColumnKind.BigInt; default: assertNever(kind); } diff --git a/extensions/ql-vscode/src/common/raw-result-types.ts b/extensions/ql-vscode/src/common/raw-result-types.ts index 9dbca7fc46f..4b5a03e243d 100644 --- a/extensions/ql-vscode/src/common/raw-result-types.ts +++ b/extensions/ql-vscode/src/common/raw-result-types.ts @@ -5,6 +5,7 @@ export enum ColumnKind { Boolean = "boolean", Date = "date", Entity = "entity", + BigInt = "bigint", } export type Column = { @@ -61,6 +62,11 @@ type CellValueNumber = { value: number; }; +type CellValueBigInt = { + type: "number"; + value: number; +}; + type CellValueString = { type: "string"; value: string; @@ -75,7 +81,8 @@ export type CellValue = | CellValueEntity | CellValueNumber | CellValueString - | CellValueBoolean; + | CellValueBoolean + | CellValueBigInt; export type Row = CellValue[];