Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luminance adjust returns NaN when an rgb value is 0 #211

Closed
GrantCuster opened this issue Jan 29, 2019 · 1 comment
Closed

Luminance adjust returns NaN when an rgb value is 0 #211

GrantCuster opened this issue Jan 29, 2019 · 1 comment

Comments

@GrantCuster
Copy link

You can reproduce if you go to https://gka.github.io/chroma.js/ and run chroma.hsl(90,1,0.5).luminance(0.5). The b value is NaN.

This was not a problem in 1.3.7.
@gka
Copy link
Owner

gka commented Feb 16, 2019

indeed, I was able to reproduce the bug. will investigate and fix

@gka gka closed this as completed in 77e0f40 Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gka @GrantCuster