Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Scanner #81

Closed
4 of 7 tasks
glebm opened this issue Aug 2, 2014 · 5 comments
Closed
4 of 7 tasks

Rework Scanner #81

glebm opened this issue Aug 2, 2014 · 5 comments
Milestone

Comments

@glebm
Copy link
Owner

glebm commented Aug 2, 2014

search:
  scanners: [[class_name, options]]
  *shared_options
  • Scanners should return result sets and not a tree.
  • Default to only scanning full keys (what is now --strict).
  • AST scanner for .rb files AST Scanner for .rb files #165

In the future (after v0.9.0), it would be nice to also have:

  • AST scanner for Temple-compatible templates.
  • Runtime collection scanner.
  • Avoid storing dynamic keys in a tree. Instead, these should be handled separately. Avoid passing dynamic keys to methods that shouldn't have to handle them (such as split_key). This need lots of work.
@glebm glebm changed the title Scanner extension API Scanner extensibility Aug 2, 2014
@glebm glebm changed the title Scanner extensibility Rework Scanner Aug 9, 2014
@atipugin
Copy link
Contributor

Any progress on it?:)

@glebm
Copy link
Owner Author

glebm commented Sep 23, 2014

Unfortunately, I don't have much time to work on this at the moment

@atipugin
Copy link
Contributor

That's sad :(

@glebm
Copy link
Owner Author

glebm commented Sep 23, 2014

I will make time to help if anyone else wants to work on this ;)

@kieranklaassen
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants