Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiple profile issue #3076

Merged
merged 10 commits into from
Sep 10, 2024
Merged

Fixed multiple profile issue #3076

merged 10 commits into from
Sep 10, 2024

Conversation

akanshaaa19
Copy link
Member

@akanshaaa19 akanshaaa19 commented Sep 8, 2024

target issue is #2998 #2911

This PR is dependent on backend PR

Copy link

github-actions bot commented Sep 8, 2024

@github-actions github-actions bot temporarily deployed to pull request September 8, 2024 13:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 8, 2024 13:33 Inactive
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.03%. Comparing base (8493c29) to head (f481aad).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3076      +/-   ##
==========================================
+ Coverage   85.98%   86.03%   +0.04%     
==========================================
  Files         322      322              
  Lines       10392    10393       +1     
  Branches     2216     2216              
==========================================
+ Hits         8936     8942       +6     
+ Misses       1358     1348      -10     
- Partials       98      103       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Sep 8, 2024

Glific    Run #5232

Run Properties:  status check passed Passed #5232  •  git commit 3115a57d41 ℹ️: Merge f481aade18a814409e56e1560c16681e02a6ade1 into 39339eff7cb15d816a55f4e2160c...
Project Glific
Branch Review fix/multiple-profiles
Run status status check passed Passed #5232
Run duration 24m 29s
Commit git commit 3115a57d41 ℹ️: Merge f481aade18a814409e56e1560c16681e02a6ade1 into 39339eff7cb15d816a55f4e2160c...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@github-actions github-actions bot temporarily deployed to pull request September 8, 2024 14:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 8, 2024 15:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 8, 2024 15:12 Inactive
@akanshaaa19 akanshaaa19 self-assigned this Sep 9, 2024
@akanshaaa19 akanshaaa19 linked an issue Sep 9, 2024 that may be closed by this pull request
@github-actions github-actions bot temporarily deployed to pull request September 9, 2024 09:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 9, 2024 09:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 9, 2024 10:00 Inactive
@akanshaaa19 akanshaaa19 linked an issue Sep 10, 2024 that may be closed by this pull request
@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 17:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 19:12 Inactive
@@ -179,6 +179,12 @@ export const FormLayout = ({
}
}, [advanceSearch]);

useEffect(() => {
Copy link
Contributor

@kurund kurund Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's discuss this during stand up.

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@kurund kurund merged commit 7e2772e into master Sep 10, 2024
10 of 11 checks passed
@kurund kurund deleted the fix/multiple-profiles branch September 10, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact History: Showing Profile Contacts: Showing Multiple Profiles
2 participants