Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add to collections #3050

Merged
merged 15 commits into from
Sep 24, 2024
Merged

Fix: Add to collections #3050

merged 15 commits into from
Sep 24, 2024

Conversation

akanshaaa19
Copy link
Member

target issue is #3025

@akanshaaa19 akanshaaa19 self-assigned this Sep 1, 2024
@akanshaaa19 akanshaaa19 linked an issue Sep 1, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 1, 2024

@github-actions github-actions bot temporarily deployed to pull request September 1, 2024 16:48 Inactive
Copy link

cypress bot commented Sep 1, 2024

Glific    Run #5276

Run Properties:  status check passed Passed #5276  •  git commit 8df5ee9bcc ℹ️: Merge f40e1343e8a68b5ac87bb827b187f1b5dc3a4c90 into 6fb541f0624cb9b38f69f7c1ac8a...
Project Glific
Branch Review fix/add-to-collections
Run status status check passed Passed #5276
Run duration 24m 15s
Commit git commit 8df5ee9bcc ℹ️: Merge f40e1343e8a68b5ac87bb827b187f1b5dc3a4c90 into 6fb541f0624cb9b38f69f7c1ac8a...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

@github-actions github-actions bot temporarily deployed to pull request September 9, 2024 06:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 11:36 Inactive
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.14%. Comparing base (6fb541f) to head (f40e134).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3050      +/-   ##
==========================================
- Coverage   86.16%   86.14%   -0.03%     
==========================================
  Files         323      323              
  Lines       10410    10378      -32     
  Branches     2218     2206      -12     
==========================================
- Hits         8970     8940      -30     
+ Misses       1337     1336       -1     
+ Partials      103      102       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request September 10, 2024 20:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 12, 2024 05:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 12, 2024 13:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 13, 2024 08:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 24, 2024 22:13 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and fixes issues for the following screens.

  • Chat screen
Screenshot 2024-09-24 at 23 41 11
  • Collection listing
Screenshot 2024-09-24 at 23 42 05

However, it's still broken for the following screen, this could be fixed separately.

  • Collection Contact listing
Screenshot 2024-09-24 at 23 42 34

@kurund kurund merged commit 9927c03 into master Sep 24, 2024
11 of 13 checks passed
@kurund kurund deleted the fix/add-to-collections branch September 24, 2024 22:47
@kurund
Copy link
Contributor

kurund commented Sep 24, 2024

@akanshaaa19 filed separate issue: #3097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to collections behaving weirdly
2 participants