Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide parts nodes for ElementNode and block params #1490

Closed
2 tasks done
patricklx opened this issue Nov 9, 2023 · 0 comments
Closed
2 tasks done

provide parts nodes for ElementNode and block params #1490

patricklx opened this issue Nov 9, 2023 · 0 comments

Comments

@patricklx
Copy link
Contributor

patricklx commented Nov 9, 2023

An ElementNode can have dots like <Foo.Bar />.
But only Foo references an upper scope param or variable in JS.
ElementNode should have a parts property with an array of nodes for each name part. Foo and Bar in the example above.

Regarding block params.
when block params are available, they are represented as strings only.
They should also be represented as AST nodes.

this is needed in eslint parser:
https://github.com/ember-cli/eslint-plugin-ember/blob/3ec4b269f8b8cc47fe8fca2110f4d671a80d0fab/lib/parsers/gjs-gts-parser.js#L264
and
https://github.com/ember-cli/eslint-plugin-ember/blob/3ec4b269f8b8cc47fe8fca2110f4d671a80d0fab/lib/parsers/gjs-gts-parser.js#L290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant