Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Unable to start freshly generated app with v1.0.0-beta.3 #228

Closed
john-griffin opened this issue Nov 25, 2019 · 6 comments
Closed

Unable to start freshly generated app with v1.0.0-beta.3 #228

john-griffin opened this issue Nov 25, 2019 · 6 comments
Labels

Comments

@john-griffin
Copy link

I wanted to test out the changes in v1.0.0-beta.3 so I cloned this repo locally and ran the following to generate and run a new glimmer app.

ember new new-glimmer-app -b ./glimmer.js/packages/@glimmer/blueprint
cd new-glimmer-app
npm start

Which produced the following error:

Build Error (RollupWithDependencies)

'setPropertyDidChange' is not exported by node_modules/@glimmer/component/dist/modules/es2017/index.js


Stack Trace and Error Report: /var/folders/b5/xtgx28d1475gcmvd_d7xfphw0000gn/T/error.dump.89b04f72c6e82676b7dd68c9f3c71820.log
(node:2493) UnhandledPromiseRejectionWarning: Error: 'setPropertyDidChange' is not exported by node_modules/@glimmer/component/dist/modules/es2017/index.js```
@pzuraq
Copy link
Member

pzuraq commented Nov 25, 2019

It looks like the import needs to be updated to pull it from @glimmer/tracking in the blueprint

@john-griffin
Copy link
Author

Thanks. I just ran npm install @glimmer/tracking --dev in the generated app but still get the same error.

@pzuraq
Copy link
Member

pzuraq commented Nov 25, 2019

Did you change the import itself? Some of your code is attempting to import from @glimmer/component

@john-griffin
Copy link
Author

Nothing in the generated code is importing setPropertyDidChange from @glimmer/component.

I was able to narrow it down to the @glimmer/test-helpers package. Removing that allows the app to at least build.

@pzuraq
Copy link
Member

pzuraq commented Nov 26, 2019

The usage I was thinking of should be here:

It looks like that has been updated though. I'm not sure if the test helpers have been updated, I think that's a separate repo, will check when I get a chance.

@john-griffin
Copy link
Author

Looks like you already the work here glimmerjs/glimmer-test-helpers#9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants