Skip to content
This repository has been archived by the owner on Jan 15, 2022. It is now read-only.

React.DOM.tr deprecation warning in React v16.0+ #381

Open
jasonblanchard opened this issue Jun 20, 2017 · 10 comments
Open

React.DOM.tr deprecation warning in React v16.0+ #381

jasonblanchard opened this issue Jun 20, 2017 · 10 comments

Comments

@jasonblanchard
Copy link
Contributor

jasonblanchard commented Jun 20, 2017

After upgrading to React v15.6.1, I'm seeing this deprecation warning:

lowPriorityWarning.js:40 Warning: Accessing factories like React.DOM.tr has been deprecated and will be removed in v16.0+. Use the react-dom-factories package instead.  Version 1.0 provides a drop-in replacement. For more info, see https://fb.me/react-dom-factories
printWarning	@	lowPriorityWarning.js:40
lowPriorityWarning	@	lowPriorityWarning.js:59
React.DOM.(anonymous function)	@	React.js:123
render	@	tr.js:78
...
...

Looks like tr.js:78 is a Reactable file.

I'm not sure if using react-dom-factories is the best solution here or refactoring it to avoid the call altogether.

@stclairdaniel
Copy link

@glittershark React 16 is out. Any updates here?

@vladnicula
Copy link

Breaks on react 16. How can we help? :)

@vladnicula
Copy link

Opened PR for this. It solved the issue for me #389

@abdulrahman-khankan
Copy link

@glittershark could you please approve the PR?

@andrewlorenz
Copy link

sadly another one of my imports bites the dust at React 16 :( looks like its time to find another good react table ...

@abdulrahman-khankan
Copy link

@andrewlorenz you can add this to your package.json instead.
"reactable": "github:abdulrahman-khankan/reactable"
I will keep it there and in contact with npm support to publish it there as well.

@andrewlorenz
Copy link

hey, great offer thanks I'll take a look.

@andrewlorenz
Copy link

@abdulrahman-khankan I'm finding that in spite of adding the pointer to your repo as you suggested, that:
a) npm install/update always tells me (i.e. even if I run it again and again):

+ [email protected]
updated 1 package in 17.533s

b) After running npm, there is no "reactable" folder in my node_modules
c) When I try to run up my app, I get the error: Cannot find module 'reactable/lib/reactable'

@abdulrahman-khankan
Copy link

It's a bug with package-lock. Happens to me often, hopefully npm will reply soon and no need to link it to GitHub anymore.

You can delete package-lock and run npm install again and it should work fine. At least that's how I solve it.

@andrewlorenz
Copy link

funnily enough I've just come back on to say I've managed to fix it exactly by doing just that! (though I'm sure I'd already tried that before and didn't get the same result). Thanks for such a prompt reply though my friend !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants