Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): prevent column dialog from going out of screen #150

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Sep 30, 2022

fixes #136

@netlify
Copy link

netlify bot commented Sep 30, 2022

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit a6c8b9c
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/633686af14655500087dc108
😎 Deploy Preview https://deploy-preview-150--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 30, 2022

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit a6c8b9c
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/633686af5c3c68000931d184
😎 Deploy Preview https://deploy-preview-150--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 35.23% // Head: 35.22% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (a6c8b9c) compared to base (eb6d88c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   35.23%   35.22%   -0.02%     
==========================================
  Files          94       94              
  Lines        7889     7893       +4     
  Branches      125      125              
==========================================
  Hits         2780     2780              
- Misses       5109     5113       +4     
Impacted Files Coverage Δ
lib/components/STableColumn.vue 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryo-gk
Copy link
Member

ryo-gk commented Oct 4, 2022

Thanks!
It's looking good.

@ryo-gk ryo-gk merged commit 944b2df into main Oct 4, 2022
@ryo-gk ryo-gk deleted the fix/table-col branch October 4, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table] Column dialog gets cut off on mobile screen
2 participants