-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add maxFileSize
validation rule
#198
Conversation
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 45.87% // Head: 46.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 45.87% 46.04% +0.17%
==========================================
Files 103 105 +2
Lines 8159 8185 +26
Branches 302 316 +14
==========================================
+ Hits 3743 3769 +26
Misses 4416 4416
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Can we have test for this? 👀
|
Nah that's fine! I think for now we only need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
fixes #197