Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add text-color props to SInputText and SInputNumber #218

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

ryo-gk
Copy link
Member

@ryo-gk ryo-gk commented Feb 1, 2023

Add the text-color props which change the color of the input value of SInputText and SInputNumber.

@ryo-gk ryo-gk added the enhancement New feature or request label Feb 1, 2023
@ryo-gk ryo-gk self-assigned this Feb 1, 2023
@netlify
Copy link

netlify bot commented Feb 1, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 67a94e8
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/63dcb1bae8f9f10007da3f78
😎 Deploy Preview https://deploy-preview-218--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 1, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 67a94e8
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/63dcb1bae0b0da0008d73e3a
😎 Deploy Preview https://deploy-preview-218--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 69.57% // Head: 69.71% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (67a94e8) compared to base (a482eee).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   69.57%   69.71%   +0.13%     
==========================================
  Files         106      106              
  Lines        8852     8891      +39     
  Branches      367      377      +10     
==========================================
+ Hits         6159     6198      +39     
  Misses       2693     2693              
Impacted Files Coverage Δ
lib/components/SInputNumber.vue 100.00% <100.00%> (ø)
lib/components/SInputText.vue 98.26% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@kiaking kiaking merged commit e03f642 into main Feb 3, 2023
@kiaking kiaking deleted the feat/add-text-color branch February 3, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants