Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): enhance SButtonGroup interface #222

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

nozomuikuta
Copy link
Contributor

Asana: N/A

This PR is to enhance SButtonGroup component in the following points:

  • Add Icon property to ButtonGroupItem interface, which is prioritized than label if both exist
  • Add disabled property to ButtonGroupItem interface
  • Add beforeText and afterText props to show some computed text (e.g. current page)
  • Add click event, which is emitted with value of the clicked button, so that beforeText and/or afterText can be calculated on the fly
  • Modernize some lines of code (e.g. defineProps with TypeScript)
  • Fix some styles (e.g. overflown inner height)

@nozomuikuta nozomuikuta self-assigned this Feb 14, 2023
@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 5f957d7
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/63ec8daf3d0ff00008689679
😎 Deploy Preview https://deploy-preview-222--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 5f957d7
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/63ec8daf9216a5000899382a
😎 Deploy Preview https://deploy-preview-222--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 76.37% // Head: 76.02% // Decreases project coverage by -0.36% ⚠️

Coverage data is based on head (5f957d7) compared to base (27223ff).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   76.37%   76.02%   -0.36%     
==========================================
  Files         106      106              
  Lines        8911     8780     -131     
  Branches      436      432       -4     
==========================================
- Hits         6806     6675     -131     
  Misses       2105     2105              
Impacted Files Coverage Δ
lib/components/SButton.vue 100.00% <100.00%> (ø)
lib/components/SButtonGroup.vue 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiaking
Copy link
Member

kiaking commented Feb 15, 2023

We've discussed this internally and made changes accordingly.

@kiaking kiaking merged commit 06f5934 into main Feb 15, 2023
@kiaking kiaking deleted the feat/enahance-button-group branch February 15, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants