feat(button): enhance SButtonGroup
interface
#222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana: N/A
This PR is to enhance
SButtonGroup
component in the following points:Icon
property toButtonGroupItem
interface, which is prioritized thanlabel
if both existdisabled
property toButtonGroupItem
interfacebeforeText
andafterText
props to show some computed text (e.g. current page)click
event, which is emitted withvalue
of the clicked button, so thatbeforeText
and/orafterText
can be calculated on the flydefineProps
with TypeScript)