Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(card): add :mode to root and header components #325

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Jul 31, 2023

This PR adds :mode to <SCard> and <SCardHeaderTitle>. This is to create this kind of card 👀 It adds "mode" to the border.

Note that <SCardFooterAction> already supports this by inheriting <SButton> props.

Screenshot 2023-07-31 at 17 39 11

@kiaking kiaking added the enhancement New feature or request label Jul 31, 2023
@kiaking kiaking requested review from cuebit and brc-dd July 31, 2023 08:42
@kiaking kiaking self-assigned this Jul 31, 2023
@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 879c392
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/64c79dd6a8f3b80008547e9b
😎 Deploy Preview https://deploy-preview-325--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 879c392
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/64c79dd657efc90008765367
😎 Deploy Preview https://deploy-preview-325--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (cc26861) 84.41% compared to head (879c392) 84.45%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   84.41%   84.45%   +0.04%     
==========================================
  Files         139      139              
  Lines       11084    11113      +29     
  Branches      491      492       +1     
==========================================
+ Hits         9357     9386      +29     
  Misses       1727     1727              
Files Changed Coverage Δ
lib/components/SCard.vue 100.00% <100.00%> (ø)
lib/components/SCardHeaderTitle.vue 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/components/card.md Outdated Show resolved Hide resolved
Co-authored-by: Cue <[email protected]>
@kiaking kiaking merged commit b5ec2db into main Jul 31, 2023
11 checks passed
@kiaking kiaking deleted the card-mode branch July 31, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants