-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(desc): add :dir
option
#332
Conversation
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
- Coverage 84.52% 84.51% -0.02%
==========================================
Files 139 139
Lines 11163 11165 +2
Branches 630 630
==========================================
Hits 9436 9436
- Misses 1727 1729 +2
☔ View full report in Codecov by Sentry. |
Ah shit, I'm gonna remove that option from story. That behaviour is expected. That's happening because "About" section has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions, otherwise LGTM 👍
Co-authored-by: Cue <[email protected]>
Co-authored-by: Cue <[email protected]>
Thanks a lot guys! |
Adds
:dir
option toSDesc
. This will align label and value horizontally.To control the divider, I've moved divider to
SDescItem
. And added additional prop to disable it.Finally, when setting
:dir
tofalse
, specify:labelWidth
to define the width of label area grid.