Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input-file): allow specifying accept and multiple on the input element #346

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Sep 28, 2023

No description provided.

@brc-dd brc-dd requested a review from kiaking September 28, 2023 05:28
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit e9c2f5b
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/651511e0700e5e0008910363
😎 Deploy Preview https://deploy-preview-346--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brc-dd brc-dd marked this pull request as draft September 28, 2023 05:30
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit e9c2f5b
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/651511e069e8330008658474
😎 Deploy Preview https://deploy-preview-346--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (206abcc) 84.84% compared to head (e9c2f5b) 84.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
- Coverage   84.84%   84.80%   -0.05%     
==========================================
  Files         142      142              
  Lines       11374    11382       +8     
  Branches      515      516       +1     
==========================================
+ Hits         9650     9652       +2     
- Misses       1724     1730       +6     
Files Coverage Δ
lib/components/SInputFile.vue 93.66% <73.33%> (-2.58%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brc-dd brc-dd marked this pull request as ready for review September 28, 2023 05:40
@brc-dd brc-dd changed the title fix(input-file): allow passing accept and multiple attrs feat(input-file): allow specifying accept and multiple on the input element Sep 28, 2023
@brc-dd
Copy link
Member Author

brc-dd commented Sep 28, 2023

We can revert the multiple related changes though. I don't exactly need it and it will break types in other projects.

@brc-dd brc-dd self-assigned this Sep 28, 2023
@brc-dd brc-dd added the enhancement New feature or request label Sep 28, 2023
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we can keep multiple option too. It might break the types but it would be easy fix 👍

@kiaking kiaking merged commit fb22baf into main Oct 2, 2023
9 of 11 checks passed
@kiaking kiaking deleted the file/accept branch October 2, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants