Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): add action column type #360

Merged
merged 2 commits into from
Oct 24, 2023
Merged

feat(table): add action column type #360

merged 2 commits into from
Oct 24, 2023

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Oct 23, 2023

refer story for usage

still need to fix some things like auto-resize and sticky columns. probably can do them later. this should unblock nia

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 5193b11
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/6537115f9e19d4000738e959
😎 Deploy Preview https://deploy-preview-360--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c38a896) 84.78% compared to head (5193b11) 84.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   84.78%   84.80%   +0.02%     
==========================================
  Files         142      143       +1     
  Lines       11381    11437      +56     
  Branches      516      653     +137     
==========================================
+ Hits         9649     9699      +50     
- Misses       1732     1738       +6     
Files Coverage Δ
lib/components/STableCellActions.vue 100.00% <100.00%> (ø)
lib/components/STableHeader.vue 92.63% <100.00%> (ø)
lib/components/STableHeaderActionItem.vue 100.00% <100.00%> (ø)
lib/components/STableHeaderActions.vue 100.00% <100.00%> (ø)
lib/composables/Table.ts 100.00% <100.00%> (ø)
lib/components/STableCell.vue 56.00% <14.28%> (-2.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 5193b11
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/6537115fe5fec9000891b013
😎 Deploy Preview https://deploy-preview-360--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! I've:

  • Adjusted the style just a bit (remove 2px gap).
  • Made mute mode default for actions since they should most likely be mute all the time.
  • Add docs for this cell type.

I've also lightly tested the position sticky but indeed it's working quite smooth, other than things you mentioned. Also need to figure out how to handle borders since if we make right column sticky, then border disappears 😅

But I agree we can do that later. I'll create issues for those. Let's release this baby 🎉

@kiaking kiaking merged commit acb1313 into main Oct 24, 2023
11 checks passed
@kiaking kiaking deleted the table-actions branch October 24, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants