fix(style): adjust bg-elv color for light mode
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kiaking
added
bug
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 79.70% 79.70%
=======================================
Files 151 151
Lines 12154 12154
Branches 517 517
=======================================
Hits 9687 9687
Misses 2467 2467 ☔ View full report in Codecov by Sentry. |
brc-dd
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust
--c-bg-elvcolor on light mode. It makes--c-bg-elvslightly darker.The issue is, while
bg-elvworks the same way n both Light/Dark mode where the higher the number is, it gets brighter (elevated), light mode has upper limit on how bright it can be and that isbg-elv-3where it reaches#ffffff.Therefore
bg-elv-4becomes darker on light mode. This is becausebg-elv-4is used to distinguish the element frombg-elv-2andbg-elv-3.Until now, we were using the same color for both
bg-elv-2andbg-elv-4. But it is a bit hard on eye when used on component like Card (with header) or table.This change makes
bg-elv-2a bit darker so that it can be a bit more easier to see the difference. Aiding the visuals.The contrast might not be enough compared to dark mode. But, we still do place texts on top of
bg-elv-2, so we can't be too dark in order to keep good contrast ratio with--c-text-2color.Card before/after
Table before/after