Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): allow line break on label #390

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Nov 15, 2023

Currently, label can't have line break. If it does, it leaks into input box. Labels shouldn't be long enough to have line break in the first place, but this is sometimes unavoidable on mobile.

Also cleaned up a bit on info and note combination handling. A bit hacky so I might wanna refactor in the future, but this should work for now 🤔

Screenshot 2023-11-15 at 12 53 59

@kiaking kiaking added the bug Something isn't working label Nov 15, 2023
@kiaking kiaking requested a review from brc-dd November 15, 2023 03:58
@kiaking kiaking self-assigned this Nov 15, 2023
Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 6355643
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/655441e17c94980008c474fc
😎 Deploy Preview https://deploy-preview-390--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 6355643
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/655441e131f9a70009d59aed
😎 Deploy Preview https://deploy-preview-390--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06ed98c) 79.52% compared to head (6355643) 79.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   79.52%   79.56%   +0.04%     
==========================================
  Files         153      153              
  Lines       12277    12302      +25     
  Branches      522      522              
==========================================
+ Hits         9763     9788      +25     
  Misses       2514     2514              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiaking kiaking merged commit 61cf155 into main Nov 15, 2023
11 checks passed
@kiaking kiaking deleted the input-label-line-break branch November 15, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants