fix(table): pass down value and record types to cells #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brc-dd
changed the title
brc-dd
commented
Nov 21, 2023
Comment on lines
+199
to
+200
| onClick(record: R): void | ||
| show?(record: R): boolean |
There was a problem hiding this comment.
these are pretty inconsistent with others. thinking consistency vs usability 🤔 (value even if introduced will always be undefined)
There was a problem hiding this comment.
Hmmmm I vote for usability here. Also, I have a feeling we could remove value from everywhere in the future version.
Since we started using Ops pattern, I see my self barely using value anymore because ops requires whole model to be passed in 🤔
{
cell: (_, user) => ({
value: userOps.fullName(user)
})
}
kiaking
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.