-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http): allow overriding fetch handler #435
Conversation
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think it would be cooler if we can hide ofetch beneath Http 🤔 How about we add config method? Http.config({
base: '...',
xsrfUrl: false
}) |
Ah, but need to replace ofetch entirely in nuxt. Maybe this: ? Http.config({
base: '...',
xsrfUrl: false,
$fetch: ... // when necessary?
}) |
Yea this makes more sense. Probably ideal to allow passing an implementation than conditional operation where dependencies are concerned. |
Oh sorry I was missing that 😳 Yeah I think your example make sense. Maybe name it |
a9c2c34
to
bdc1d72
Compare
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looking smooth 👍
Bit of a breaking change: