Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(url): handle array value when corresponding target is non-array #505

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Mar 27, 2024

target[key] can be undefined in certain cases in those cases calling splice will throw error. splice call is there to maintain reactivity in array but if there is nothing by default there is no need to maintain reactivity

@brc-dd brc-dd requested a review from kiaking as a code owner March 27, 2024 18:31
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit e91791e
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/660465ebdb85730008e4f105
😎 Deploy Preview https://deploy-preview-505--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit e91791e
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/660465eb9a7b7f00082995fe
😎 Deploy Preview https://deploy-preview-505--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kiaking kiaking merged commit 7a5727e into main Mar 28, 2024
9 checks passed
@kiaking kiaking deleted the fix/deep-assign-edge-case branch March 28, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants