Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(avatar): support showing name as tooltip #515

Closed
wants to merge 53 commits into from
Closed

feat(avatar): support showing name as tooltip #515

wants to merge 53 commits into from

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Apr 8, 2024 •
edited
Loading

brc-dd added 30 commits April 5, 2024 11:05
@brc-dd
feat: teleport tooltip to avoid stacking issues
e4cb517
@brc-dd
add teleport target globally
c281cbf
@brc-dd
add teleport target to vitepress
4b7483b
@brc-dd
vitepress ssr teleports
a9c0b94
@brc-dd
skip tests
0c1bcc7
@brc-dd
preserve visibility
c4eabdc
@brc-dd
update comment
d83b719
@brc-dd
hide on scroll
bd56ef7
@brc-dd
use absolute positioning instead of fixed
ced0ef5
@brc-dd
show preview story url in docs if previewing
01eb520
@brc-dd
show preview docs url in story if previewing
ce8e9ef
@brc-dd
handle padding via css and dont hide tooltip while selecting text fro…
bc3deee 
…m tip and adjust naming to align with composable
@brc-dd
restore timeout logic and working tests
eb9b01c
@brc-dd
move stuff to vitest setup file
28513a0
@brc-dd
fix histoire auto complete
ebf9cea
@brc-dd
move shims outside
b7a33a3
@brc-dd
add 200ms delay to avoid showing tooltip while scrolling past some te…
c3d9a0d 
…xt and fix logic
@brc-dd
move more stuff to vitest setup
362f190
@brc-dd
shims for vue are not needed
ce62237
@brc-dd
update path
75dc621
@brc-dd
fix false positives
ba5a6fe
@brc-dd
handled undefined too
f455c16
@brc-dd
try hiding on click outside
ee9416c
@brc-dd
prevent hide from triggering multiple times and make event listeners …
bfb9b94 
…passive
@brc-dd
manually run cleanups to avoid issues with bf-cache
fef4b16
@brc-dd
add event listeners globally
b95d211
@brc-dd
delay set and eager reset globalHide
2758e41
@brc-dd
globalHide is redundant
bfdc54d
@brc-dd
revert
ed05017
@brc-dd
revert
3cdd752
@brc-dd
fix hydration mismatch (p is not allowed as a child of span) and set …
3b24b0b 
…line-height on initials to align tooltips between name only and image avatars
@brc-dd brc-dd marked this pull request as draft April 8, 2024 10:35
@brc-dd brc-dd changed the base branch from main to popover-tooltip April 10, 2024 04:50
@brc-dd brc-dd changed the base branch from popover-tooltip to main April 10, 2024 06:14
@brc-dd brc-dd marked this pull request as ready for review April 10, 2024 06:14
@brc-dd brc-dd self-assigned this Apr 10, 2024
@brc-dd brc-dd added the enhancement New feature or request label Apr 10, 2024
@brc-dd brc-dd mentioned this pull request Apr 10, 2024
Merged
1 task
@brc-dd brc-dd changed the base branch from main to popover-tooltip April 10, 2024 20:25
@brc-dd brc-dd changed the base branch from popover-tooltip to main April 10, 2024 20:34
@brc-dd brc-dd changed the title feat: show name on hovering avatars feat(avatar): support showing name as tooltip Apr 10, 2024
@brc-dd brc-dd changed the base branch from main to popover-tooltip April 16, 2024 06:56
@brc-dd brc-dd changed the base branch from popover-tooltip to main April 16, 2024 06:57
@brc-dd brc-dd closed this in 7f2abd1 May 2, 2024
@brc-dd brc-dd deleted the avatar-tooltip branch May 2, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiaking kiaking Awaiting requested review from kiaking kiaking is a code owner

Assignees

@brc-dd brc-dd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brc-dd